Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Makefile deploy rule dependency and improve error checking for invalid assets #4203

Merged
merged 4 commits into from
May 6, 2019
Merged

Fix Makefile deploy rule dependency and improve error checking for invalid assets #4203

merged 4 commits into from
May 6, 2019

Conversation

tstromberg
Copy link
Contributor

@tstromberg tstromberg commented May 3, 2019 •
edited
Loading

Instead of an obscure runtime read panic, minikube will now panic on initialization if it has been compiled with invalid assets:

panic: Failed to define asset deploy/addons/addon-manager.yaml: Asset deploy/addons/addon-manager.yaml not found

or:

panic: Failed to define asset deploy/addons/addon-manager.yaml: deploy/addons/addon-manager.yaml is an empty asset

Closes #3555

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 3, 2019
@tstromberg tstromberg requested a review from medyagh May 3, 2019 23:19
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 3, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 3, 2019
medyagh
medyagh approved these changes May 3, 2019
View reviewed changes
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me !

@sharifelgamal
Copy link
Collaborator

The travis failure looks both real and unrelated to this change. The change itself LGTM.

@afbjorklund
Copy link
Collaborator

Looks good, hope it helps you catch the real error. Time to remove the WIP, perhaps ?

@tstromberg tstromberg added this to the v1.1.0 milestone May 6, 2019
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 6, 2019
@tstromberg tstromberg changed the title WIP: Avoid calling Read() on 0-byte resources, and add copious debugging. Improve error checking for invalid assets May 6, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 6, 2019
@tstromberg tstromberg changed the title Improve error checking for invalid assets Fix Makefile deploy rule dependency and improve error checking for invalid assets May 6, 2019
@medyagh medyagh self-requested a review May 6, 2019 18:53
medyagh
medyagh approved these changes May 6, 2019
View reviewed changes
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@tstromberg tstromberg merged commit 2ddd4c5 into kubernetes:master May 6, 2019
@medyagh medyagh mentioned this pull request Jun 5, 2019
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh approved these changes

@sharifelgamal sharifelgamal sharifelgamal approved these changes

@afbjorklund afbjorklund Awaiting requested review from afbjorklund

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

minikube start -> panic: runtime error: invalid memory address or nil pointer dereference
5 participants
@tstromberg @k8s-ci-robot @sharifelgamal @afbjorklund @medyagh